fix: range balance strategy not like reference #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
njhartwell
commented
Jun 6, 2022
| pos := float64(i) | ||
| min := int(math.Floor(pos*step + 0.5)) | ||
| max := int(math.Floor((pos+1)*step + 0.5)) | ||
| min := i*partitionsPerConsumer + int(math.Min(float64(consumersWithExtraPartition), float64(i))) |
There was a problem hiding this comment.
The float math version is more concise, but gives different results than the reference implementation (e.g. when there are more members than available partitions, it assigns them to the middle of the list instead of the beginning).
|
@njhartwell thanks for working on this. Are you happy to sign the Shopify CLA under your GitHub username? |
|
Just signed it |
dnwe
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kafka.apache.org/31/javadoc/org/apache/kafka/clients/consumer/RangeAssignor.html